Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix if-check npm tests after merge #1092

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix if-check npm tests after merge #1092

merged 1 commit into from
Dec 6, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

A description of the changes proposed in the Pull Request

@narekhovhannisyan narekhovhannisyan self-assigned this Dec 6, 2024
jmcook1186
jmcook1186 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@narekhovhannisyan narekhovhannisyan merged commit 7e3859f into main Dec 6, 2024
4 checks passed
@narekhovhannisyan narekhovhannisyan deleted the fix-npm-test branch December 6, 2024 13:53
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak Awaiting requested review from manushak

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narekhovhannisyan @jmcook1186